[
https://issues.apache.org/jira/browse/THRIFT-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351582#comment-14351582
]
Hudson commented on THRIFT-3023:
--------------------------------
SUCCESS: Integrated in Thrift #1473 (See
[https://builds.apache.org/job/Thrift/1473/])
THRIFT-3023 Go compiler is a little overly conservative with names of
attributes (jensg: rev 28c1c19f913a4bee97a8309cf4b65914f705faea)
* lib/go/test/Makefile.am
* compiler/cpp/src/generate/t_go_generator.cc
* lib/go/test/NamesTest.thrift
* lib/go/test/tests/names_test.go
> Go compiler is a little overly conservative with names of attributes
> --------------------------------------------------------------------
>
> Key: THRIFT-3023
> URL: https://issues.apache.org/jira/browse/THRIFT-3023
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler
> Affects Versions: 0.9.2
> Reporter: Paul Magrath
> Assignee: Jens Geyer
> Fix For: 0.9.3
>
>
> Go compiler, in attempting to avoid using variable names that are reserved
> words in Go, is being a little overly conservative.
> For example, if you have a struct like this:-
> {code}
> struct NamesTest {
> 1: required string type
> }
> {code}
> One would expect it to compile to:-
> {code}
> type NamesTest struct {
> Type string `thrift:"type,1,required" json:"type"`
> }
> {code}
> Rather than:-
> {code}
> type NamesTest struct {
> TypeA1 string `thrift:"type,1,required" json:"type"`
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
