Ya, thanks for the patch! Hope to have a reference Docker container for build/test soon to make it easier for contribs to add value. Getting a build going from scratch can be quite a challenge at present.
On Thu, Mar 26, 2015 at 4:16 PM, Willyham <[email protected]> wrote: > Github user Willyham commented on the pull request: > > https://github.com/apache/thrift/pull/403#issuecomment-86750849 > > Hey Randy, > > Thank you. I was having trouble building the entire test suite on my > distro. I should note that the NodeJS specific tests which run with `npm > test` all passed after I patched them, so there must be some missing > coverage in those. Thanks for finishing this up. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at [email protected] or file a JIRA ticket > with INFRA. > --- >
