[
https://issues.apache.org/jira/browse/THRIFT-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393874#comment-14393874
]
ASF GitHub Bot commented on THRIFT-3066:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/420
[THRIFT-3066] fix assert that was assigning
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift
bugfix/THRIFT-3066-assert-that-assigns-value
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/420.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #420
----
commit f10c377f7a332194bf797e6b194e25ee9b34df42
Author: Jim King <[email protected]>
Date: 2015-04-03T01:15:34Z
[THRIFT-3066] fix assert that was assigning
----
> C++ TDenseProtocol assert modifies instead of checks
> ----------------------------------------------------
>
> Key: THRIFT-3066
> URL: https://issues.apache.org/jira/browse/THRIFT-3066
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.2
> Reporter: James E. King, III
> Priority: Minor
>
> cppcheck-1.68 found an assertion that is assigning a value:
> {noformat} // If this is the end of the top-level write, we should have just
> popped
> // the TypeSpec passed to the constructor.
> if (ts_stack_.empty()) {
> assert(old_tts = type_spec_);
> return;
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
