[
https://issues.apache.org/jira/browse/THRIFT-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395911#comment-14395911
]
ASF GitHub Bot commented on THRIFT-3077:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/426
[THRIFT-3077] TFileTransport fix ignored ftruncate result
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift
bugfix/THRIFT-3077-ftruncate-ignored-result
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/426.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #426
----
commit 25e54c7cbdfc087af86ad91868680c003f2af677
Author: Jim King <[email protected]>
Date: 2015-04-04T19:58:57Z
[THRIFT-3077] TFileTransport fix ignored ftruncate result
----
> C++ TFileTransport ignores return code from ftruncate
> -----------------------------------------------------
>
> Key: THRIFT-3077
> URL: https://issues.apache.org/jira/browse/THRIFT-3077
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.3
> Reporter: James E. King, III
> Priority: Minor
>
> If ftruncate fails, nobody will know...
> {code}src/thrift/transport/TFileTransport.cpp: In member function 'void
> apache::thrift::transport::TFileTransport::writerThread()':
> src/thrift/transport/TFileTransport.cpp:316:34: warning: ignoring return
> value of 'int ftruncate(int, __off_t)', declared with attribute
> warn_unused_result [-Wunused-result]
> THRIFT_FTRUNCATE(fd_, offset_);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
