[ 
https://issues.apache.org/jira/browse/THRIFT-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491407#comment-14491407
 ] 

Hudson commented on THRIFT-3091:
--------------------------------

SUCCESS: Integrated in Thrift #1500 (See 
[https://builds.apache.org/job/Thrift/1500/])
THRIFT-3091 c_glib service method should return result from handler method 
(roger: rev 6d71dc868873691a62b3cb28bf48dcb0e225fa95)
* compiler/cpp/src/generate/t_c_glib_generator.cc


> c_glib service method should return result from handler method
> --------------------------------------------------------------
>
>                 Key: THRIFT-3091
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3091
>             Project: Thrift
>          Issue Type: Bug
>          Components: C glib - Compiler
>            Reporter: Nobuaki Sukegawa
>            Assignee: Nobuaki Sukegawa
>             Fix For: 0.9.3
>
>
> Generated c_glib service method has *gboolean* return type but actually 
> returned nothing at all.
> It seems that while gcc 4.9.2 treats it as if returning non-zero, clang 3.6.0 
> treats it as if returning zero.
> The patch adds missing "return " to implementation(handler) method call in 
> the last line of service method.
> Note that it also includes style fix (0 -> FALSE) in the same line which is 
> not essential.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to