[ 
https://issues.apache.org/jira/browse/THRIFT-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492588#comment-14492588
 ] 

ASF GitHub Bot commented on THRIFT-3094:
----------------------------------------

GitHub user jeking3 opened a pull request:

    https://github.com/apache/thrift/pull/439

    THRIFT-3094 fix broken cmake build of C++ library with alternate threading

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jeking3/thrift 
bugfix/THRIFT-3094-cmake-build-alt-threading

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/439.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #439
    
----
commit f231b4450cdac437aaf3324503d85cb8325f8d6a
Author: Jim King <[email protected]>
Date:   2015-04-13T16:25:35Z

    THRIFT-3094 fix broken cmake build of C++ library with alternate threading

----


> master as of 2015-APR-13 fails -DBOOST_THREADS cmake build
> ----------------------------------------------------------
>
>                 Key: THRIFT-3094
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3094
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.3
>         Environment: Travis CI cmake build with the options:
> export CMAKE_CONFIG="-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON"
> export CMAKE_CONFIG="-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF 
> -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON"
> Also fails on Ubuntu 12.04.1 LTS.
>            Reporter: James E. King, III
>            Priority: Blocker
>
> As seen in Build 1196 (https://travis-ci.org/apache/thrift/builds/58288894) 
> two cmake builds are failing and I was able to reproduce it locally:
> Linking CXX executable ../../bin/StressTest
> Linking CXX executable ../../bin/StressTestNonBlocking
> CMakeFiles/StressTest.dir/src/StressTest.cpp.o:StressTest.cpp:function main: 
> error: undefined reference to 
> 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY,
>  apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)'
> collect2: ld returned 1 exit status
> make[2]: *** [bin/StressTest] Error 1
> make[1]: *** [test/cpp/CMakeFiles/StressTest.dir/all] Error 2
> make[1]: *** Waiting for unfinished jobs....
> [ 85%] Building CXX object 
> lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/OptionalRequiredTest_types.cpp.o
> [ 86%] Building CXX object 
> lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/Recursive_types.cpp.o
> CMakeFiles/StressTestNonBlocking.dir/src/StressTestNonBlocking.cpp.o:StressTestNonBlocking.cpp:function
>  main: error: undefined reference to 
> 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY,
>  apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)'
> collect2: ld returned 1 exit status
> make[2]: *** [bin/StressTestNonBlocking] Error 1
> make[1]: *** [test/cpp/CMakeFiles/StressTestNonBlocking.dir/all] Error 2
> Was Travis CI recently changed to make these mandatory build jobs when they 
> were optional before?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to