[
https://issues.apache.org/jira/browse/THRIFT-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494712#comment-14494712
]
Hudson commented on THRIFT-3062:
--------------------------------
SUCCESS: Integrated in Thrift #1507 (See
[https://builds.apache.org/job/Thrift/1507/])
THRIFT-3062 fix segfault on invalid port number (roger: rev
efd14e7c2521c3210531f1893719905ea8a0835e)
* lib/cpp/test/TServerSocketTest.cpp
* lib/cpp/src/thrift/transport/TServerSocket.cpp
* lib/cpp/test/TTransportCheckThrow.h
* lib/cpp/src/thrift/transport/TSocket.cpp
> C++ TServerSocket invalid port number (over 999999) causes stack corruption
> ---------------------------------------------------------------------------
>
> Key: THRIFT-3062
> URL: https://issues.apache.org/jira/browse/THRIFT-3062
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.2
> Reporter: James E. King, III
> Labels: security
> Fix For: 0.9.3
>
> Attachments: THRIFT-3062.patch
>
>
> In {{TServerSocket::listen()}} a buffer of size 7 is allocated for the string
> to numeric translation of the port number, defined as {{int}}:
> {noformat} char port[sizeof("65536") + 1];
> ...
> sprintf(port, "%d", port_);{noformat}
> An input of 1000000 or more will cause stack corruption. Recommend changing
> sprintf to something safer, or making a larger buffer. In this case, one can
> safely allocate a fixed size buffer on the stack to accomodate the largest
> result possible, avoiding the problem. Alternatively, ensure the input is
> bound, which is what {{TSocket::localOpen()}} does.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
