Marco Molteni created THRIFT-3097:
-------------------------------------
Summary: cmake targets unconditionally depend on optional libraries
Key: THRIFT-3097
URL: https://issues.apache.org/jira/browse/THRIFT-3097
Project: Thrift
Issue Type: Bug
Affects Versions: 1.0
Environment: Bug found on Linux Ubuntu 14.10, but it should be present
anywhere.
Reporter: Marco Molteni
if the optional libraries are not installed, the _default_ cmake build fails.
h2. How to reproduce
h3. Case 1
- "cmake -D WITH_LIBEVENT=OFF" (or just "cmake" on a system without libevent)
- make
{noformat}
Linking CXX executable ../../bin/StressTest
/usr/bin/ld: cannot find -lthriftnb
{noformat}
h3. Case 2
- "cmake" on a system with Python installed but *not* package python-dev
- make
{noformat}
Building Python library
/usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution
option: 'use_2to3'
warnings.warn(msg)
running build
running build_py
running build_ext
building 'thrift.protocol.fastbinary' extension
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes
-fno-strict-aliasing -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat
-Werror=format-security -fPIC -I/usr/include/python2.7 -c
src/protocol/fastbinary.c -o
build/temp.linux-x86_64-2.7/src/protocol/fastbinary.o
src/protocol/fastbinary.c:20:20: fatal error: Python.h: No such file or
directory
#include <Python.h>
{noformat}
Will issue a github pull request.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
