Github user jeremy-w commented on the pull request:
https://github.com/apache/thrift/pull/442#issuecomment-94001001
It would be nice if this built cleanly with the following warning config:
`OTHER_CFLAGS = -Wall -Wextra -Weverything -Wno-objc-missing-property-synthesis
-Wno-unused-parameter -Wno-auto-import -Wno-documentation-unknown-command
-Wno-direct-ivar-access -Wno-objc-interface-ivars -fno-objc-arc`
This finds a lot of implicit conversion and ARC issues. Many of those are
due to TProtocol.h not being updated similarly to TBinaryProtocol.h to avoid
unnecessary indirect returns (and, under ARC, the need for `__autoreleasing`),
like `- (void) readStructBeginReturningName: (NSString **) name;` which could
simply return the name directly.
I know that's a pain though, and I don't want to hold up adding a compact
protocol, so we could add an issue to fix this up in a later PR. (More
generally, we really need an actual Xcode project with consistent build
configuration, and actual protocol tests.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
