[ 
https://issues.apache.org/jira/browse/THRIFT-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500016#comment-14500016
 ] 

Jeremy W. Sherman commented on THRIFT-2640:
-------------------------------------------

As the last comment says, I only see 1 small issue needing a fix before 
applying the changes, but there are a lot of other issues that should be 
cleaned up in a later pass.

[~jensg] What would be the best way to go about adding an Xcode project file, 
so authors can be consistent in which warnings are observed? It would be used 
during development, but we wouldn't want to copy it into a release tarball.

I'm also curious if there's any documentation on adding tests for a language / 
how the testrunner system works. Unless the tests are being run under OS X, it 
wouldn't be possible to run the tests as part of whatever buildbot/CI system is 
in place, but it would still be useful during patch review.

The Cocoa lib currently has no tests, and that makes it unfortunately terribly 
easy to miss a feature (like service inheritance) or bungle something in an 
edit and fail to catch it.

If I'd do better asking these questions in an email to thrift-dev@, I've no 
problem moving them there.

Thanks!

> Compact Protocol in Cocoa
> -------------------------
>
>                 Key: THRIFT-2640
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2640
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Cocoa - Library
>    Affects Versions: 0.9.1
>            Reporter: Mark Hornsby
>            Assignee: Jens Geyer
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to