[
https://issues.apache.org/jira/browse/THRIFT-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500833#comment-14500833
]
ASF GitHub Bot commented on THRIFT-3105:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/453
THRIFT-3105 fix TNonBlockingServer build for libthriftnb library on windows
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift
bugfix/THRIFT-3105-win-libcpp-build-error
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/453.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #453
----
commit 0ffbb4336b6174efbdf89462e4671325f174d4f0
Author: Jim King <[email protected]>
Date: 2015-04-17T22:42:00Z
THRIFT-3105 fix TNonBlockingServer build for libthriftnb library on windows
----
> C++ libthriftnb library on Windows build failure
> ------------------------------------------------
>
> Key: THRIFT-3105
> URL: https://issues.apache.org/jira/browse/THRIFT-3105
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.2
> Environment: Visual Studio 2010, Boost 1.53, OpenSSL 1.0.1b, libevent
> 2.0.22
> Reporter: James E. King, III
>
> Attempted to build libthriftnb and got a build failure:
> {noformat}1>------ Build started: Project: libthriftnb, Configuration: Debug
> Win32 ------
> 1> TNonblockingServer.cpp
> 1>c:\users\jim\workspace\thrift\lib\cpp\src\thrift\server\tnonblockingserver.cpp(1110):
> error C2664: 'getsockname' : cannot convert parameter 3 from 'unsigned int
> *' to 'int *'
> 1> Types pointed to are unrelated; conversion requires
> reinterpret_cast, C-style cast or function-style cast
> 1> TEvhttpServer.cpp
> 1> TEvhttpClientChannel.cpp
> 1> Generating Code...
> ========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========
> {noformat}
> The type for the size should be changed to "socklen_t", it is declared as
> "unsigned int". TSocket uses this as well, and it works across platforms.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
