Github user arijitvt commented on the pull request:
https://github.com/apache/thrift/pull/444#issuecomment-96660406
Should I fix these changes and create a new pull request?
Arijit
On Mon, Apr 27, 2015 at 3:22 AM, Aki Sukegawa <[email protected]>
wrote:
> @bufferoverflow <https://github.com/bufferoverflow>
> Could you revert (undo) part of the commit corresponding to third commit
> of this pull request ?
> This (d1aa530
>
<https://github.com/apache/thrift/commit/d1aa53086c286bda716b7414eb04042999bb070a>)
> breaks Travis build by inserting non-code to YAML.
>
> By the way, the second one (711e608
>
<https://github.com/apache/thrift/commit/711e6081fa8d31ffce3d6c431e0cd6c3dad9f050>)
> only breaks the style of existing code.
> It would be nice if this change is removed too.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/thrift/pull/444#issuecomment-96528996>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
