Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/469#discussion_r29297937
--- Diff: tutorial/tutorial.thrift ---
@@ -113,7 +113,7 @@ struct Work {
* Structs can also be exceptions, if they are nasty.
*/
exception InvalidOperation {
- 1: i32 what,
+ 1: i32 what_op,
--- End diff --
1. this naming convention is inconsistent with rest of tutorial.thrift file
(camelCase)
2. changing it here requires update in all tutorials, not only C++
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
