I think it is easier to store such info in Jira - we do reference jira
issue in each commit, so all additional info could be in Jira.
Especially that it simplifies providing such info (user list etc.) and
searching in it.
But even if we do change our commit message (I personally do not like
"Client:" part, I'd prefer "Component:") then still we have to decide
"how jira integrates into our workflow".
(If we change information in JIra and/or commit message we could leave
original authors of commits, which could make contributors more happy -
having an authored commit in Apache repo).
-kg
W dniu 2015-05-03 o 21:41, Roger Meier pisze:
I we would use proper git commit message such as used on Linux Kernel
and many other project (also at Apache), there would be no such Problems.
Signed-off-by: Random J Developer <[email protected]>
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n407
and Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n537
and we can just use git to set and get all the information and use
standard git, such as
- git commit -s -a
- git am -s THRIFT-9999.patch
- git push
best!
-roger
Quoting Konrad Grochowski <[email protected]>:
Hi All,
Recent discussion in
https://issues.apache.org/jira/browse/THRIFT-3105 shows that maybe we
need to redesign our Jira workflow.
As for now I see couple of problems:
1. not every user can be assigned to issue. As long as we use
"Assignee" field to indicate "patch author" this makes it trouble
some. I was unable to find how to add user to "allowed assignees" in
Jira, but maybe I have wrong role in Jira project myself.
2. We loose information who did commit patch. After few months it's
hard to expect some contributor to rethink his/hers patch when some
problems appear, yet we could expect commiter to be an 'expert' in
issue he worked on (assuming it was more work than 'git apply; git
commit -a; git push' ;) ).
3. We lack ability to mark issue as "Commiter is working on applying
patch".
4. "Close" state usability is unclear - who should close issue, when,
what kind of issues can be closed etc.
My suggested solution:
a. Add new field to Jira issues - Patch Author (we already have
"Patch Available" so it would be consistent) with ability to assign
any Jira user to it. This field should be required on Open ->
Resolved transition screen.
b. Use Assignee field to indicate commiter who is working on applying
issue. When issue is resolved - it should point to author of commit.
c. Remove 'Closed' state as it seems to not provide any additional
information.
Just a topic to discussion :)
Best regards,
Konrad
