[ 
https://issues.apache.org/jira/browse/THRIFT-3123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526315#comment-14526315
 ] 

ASF GitHub Bot commented on THRIFT-3123:
----------------------------------------

GitHub user ehrmann opened a pull request:

    https://github.com/apache/thrift/pull/477

    THRIFT-3123: Include stdio.h to get a definition for FILE

    `FILE` is referenced on line 102 `extern FILE* yyin;`. I was cross 
compiling, and the definition for `FILE` not being included caused the build to 
fail, so I included it. I built again on Debian and FreeBSD, and it builds fine 
with the change

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ehrmann/thrift THRIFT-3123

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/477.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #477
    
----
commit c5f12960e7764dabe0a155e80ec256786ed06a1f
Author: David Ehrmann <[email protected]>
Date:   2015-05-04T06:05:30Z

    Include stdio.h to get a definition for FILE

----


> Missing include in compiler/cpp/src/main.h breaks build in some environments
> ----------------------------------------------------------------------------
>
>                 Key: THRIFT-3123
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3123
>             Project: Thrift
>          Issue Type: Bug
>            Reporter: David Ehrmann
>            Priority: Minor
>
> main.h uses FILE. In a build environment where stdio.h isn't implicitly 
> included, this will be undefined. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to