[
https://issues.apache.org/jira/browse/THRIFT-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526650#comment-14526650
]
ASF GitHub Bot commented on THRIFT-3122:
----------------------------------------
Github user itkach commented on the pull request:
https://github.com/apache/thrift/pull/476#issuecomment-98714766
> BonkSet, which in C++ will require comparison operators,
That is a strange requirement and it's not clear how would one go about
providing such comparison operators for generated classes - looks like an issue
with C++ code to me. But this is another discussion. I will restore
ThriftTest.thrift to the way it was and will create a new .thrift file for my
test .
> I also wonder if the compiler is the right place to add the
__thriftCopyXXX functions, I think they should probably belong to the library
code.
That's easy for nodejs, but in a browser environment user would have to
explicitly add dependency on this new library via <script> tag (which is
internal implementation detail and is not to be used for the client code
directly), otherwise generated code would be broken "out of the box". So I
think compiler is, unfortunately, the right place for these functions.
Ideally there would be no compiler for js and no generated javascript at
all, I think it should all be library code that works off of the spec (say
spec'c json representation), but that's not the current approach and is a
discussion for another day.
> Javascript struct constructor should properly initialize struct and container
> members from plain js arguments
> -------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-3122
> URL: https://issues.apache.org/jira/browse/THRIFT-3122
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Compiler
> Reporter: Igor Tkach
>
> Currently constructors for struct types in generated javascript accept
> {{args}} object and initialize struct's members by simply assigning a value
> from corresponding {{args}} object property (if not undefined). If struct
> member is
> another struct it must be explicitly created with constructor and passed as
> an argument value.
> Given following definitions:
> {code}
> struct A {
> 1: string something
> }
> struct B {
> 1: A value
> }
> {code}
> this works:
> {code:javascript}
> var b1 = new B(
> {
> value: new A(
> {
> something: 'hello'
> }
> )
> }
> );
> {code}
> this doesn't:
> {code:javascript}
> var b2 = new B(
> {
> value: {
> something: 'hello'
> }
> }
> );
> {code}
> Attempt to serialize b2 will result in error because {{b2.a}} doesn't have a
> {{write}} method.
> This becomes especially problematic when deep objects are used with libraries
> like [Underscore.js|http://underscorejs.org/], [lodash|https://lodash.com/],
> [React's immutability
> helpers|https://facebook.github.io/react/docs/update.html] or
> [Immutable.js|https://github.com/facebook/immutable-js]: most operations will
> return or produce plain javascript objects without read/write methods even if
> Thrift objects were given as input. Manually converting object graphs back to
> Thrift serializable form is not workable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
