[ https://issues.apache.org/jira/browse/THRIFT-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530672#comment-14530672 ]
James E. King, III commented on THRIFT-3121: -------------------------------------------- I added these tests, so I caused the issue. But I have some issues with the fix: 1. The CI build failed - why was this merged? 2. The fix only addresses CMake. Was it not necessary to update autoconf? 3. I think it would have been better to use CMake and autoconf to detect the presence of librt and include it as a platform dependency instead of putting it into the lib/cpp/test makefile. librt is required on linux when you use boost::chrono. > Librt does not exist on OS X > ---------------------------- > > Key: THRIFT-3121 > URL: https://issues.apache.org/jira/browse/THRIFT-3121 > Project: Thrift > Issue Type: Bug > Components: Test Suite > Environment: OSX > Reporter: Thomas Bartelmess > Fix For: 0.9.3 > > > THRIFT-2441 introduced a dependency on librt which does not exist on OS X -- This message was sent by Atlassian JIRA (v6.3.4#6332)