[ https://issues.apache.org/jira/browse/THRIFT-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530933#comment-14530933 ]
ASF GitHub Bot commented on THRIFT-2474: ---------------------------------------- GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/482 THRIFT-2474 complete the ntohll precompile conditionals You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-2474-htonll-ntohll-already-defined Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/482.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #482 ---- commit 7b3a1372f7831423d75688e0cf7d9282be103d54 Author: Jim King <jim.k...@simplivity.com> Date: 2015-05-06T13:51:54Z THRIFT-2474 complete the ntohll precompile conditionals ---- > thrift.h causes a compile failure > --------------------------------- > > Key: THRIFT-2474 > URL: https://issues.apache.org/jira/browse/THRIFT-2474 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Affects Versions: 0.9.1 > Reporter: Vitali Lovich > Assignee: James E. King, III > Priority: Minor > > ntohll & htonll are incorrectly assumed to be undefined if not glibc/MSVC. > Instead they should be protected by ifndef in case the platform provides them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)