[
https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531807#comment-14531807
]
James E. King, III edited comment on THRIFT-3130 at 5/7/15 1:27 AM:
--------------------------------------------------------------------
Well, this compiled clean:
{noformat}
template<class TServerType>
class TServerIntegrationProcessorFactoryTestFixture : public
TServerIntegrationTestFixture<TServerType>
{
public:
TServerIntegrationProcessorFactoryTestFixture() :
TServerIntegrationTestFixture<TServerType>(
boost::make_shared<ParentServiceProcessorFactory>(
boost::make_shared<ParentServiceIfSingletonFactory>(
boost::make_shared<ParentHandler>()))) { }
};
template<class TServerType>
class TServerIntegrationProcessorTestFixture : public
TServerIntegrationTestFixture<TServerType>
{
public:
TServerIntegrationProcessorTestFixture() :
TServerIntegrationTestFixture<TServerType>(
boost::make_shared<ParentServiceProcessor>(
boost::make_shared<ParentHandler>())) { }
};
{noformat}
TProcessorFactory and TProcessor have no common base - there shouldn't be any
confusion and there isn't.
I've updated the pull request with this change.
was (Author: jking3):
Well, this compiled clean:
{noformat}
template<class TServerType>
class TServerIntegrationProcessorFactoryTestFixture : public
TServerIntegrationTestFixture<TServerType>
{
public:
TServerIntegrationProcessorFactoryTestFixture() :
TServerIntegrationTestFixture<TServerType>(
boost::make_shared<ParentServiceProcessorFactory>(
boost::make_shared<ParentServiceIfSingletonFactory>(
boost::make_shared<ParentHandler>()))) { }
};
template<class TServerType>
class TServerIntegrationProcessorTestFixture : public
TServerIntegrationTestFixture<TServerType>
{
public:
TServerIntegrationProcessorTestFixture() :
TServerIntegrationTestFixture<TServerType>(
boost::make_shared<ParentServiceProcessor>(
boost::make_shared<ParentHandler>())) { }
};
{noformat}
TProcessorFactory and TProcessor have no common base - there shouldn't be any
confusion and there isn't.
> Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316
> ---------------------------------------------------------------
>
> Key: THRIFT-3130
> URL: https://issues.apache.org/jira/browse/THRIFT-3130
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9.2
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
>
> In THRIFT-1316 some macros were added that have proven to be unnecessary.
> They were partially eliminated in THRIFT-3083, and this traces the removal of
> what was left. In addition, TOutput was moved to its own class, and since
> TThrift.cpp only contained TOutput code, it was renamed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
