[
https://issues.apache.org/jira/browse/THRIFT-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532578#comment-14532578
]
Ben Craig commented on THRIFT-1944:
-----------------------------------
To recap from earlier in the thread...
"
1) sockaddr type isn't always large enough for the return of getsockname.
sockaddr_storage is recommended data type for this. I think main case is ipv6
2) errno is not the correct method of getting the error in windows. Should
be WSAGetLastError().
"
Both of those bugs are still present in head
> Binding to zero port
> --------------------
>
> Key: THRIFT-1944
> URL: https://issues.apache.org/jira/browse/THRIFT-1944
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9
> Environment: All platforms
> Reporter: Akshat Aranya
> Assignee: Ben Craig
> Labels: bind
> Attachments: patch-THRIFT-1944-java.patch,
> patch-THRIFT-1944-updated.patch, patch-THRIFT-1944.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch builds upon a previously submitted patch that was not accepted
> (THRIFT-966). The purpose of this patch is to allow TServerSocket to bind to
> port zero, that is, have the server socket be assigned a port by the OS.
> This patch provides a way to query the port after the socket has been bound
> and determine the OS assigned port
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
