[
https://issues.apache.org/jira/browse/THRIFT-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537173#comment-14537173
]
Hudson commented on THRIFT-1248:
--------------------------------
SUCCESS: Integrated in Thrift #1541 (See
[https://builds.apache.org/job/Thrift/1541/])
THRIFT-1248 fix TMemoryBuffer pointer arithmetic and add unit test (roger: rev
6077481139933b927397c7da0088aa4678f9fb3c)
* lib/cpp/src/thrift/transport/TBufferTransports.cpp
* lib/cpp/test/TMemoryBufferTest.cpp
> pointer subtraction in TMemoryBuffer relies on undefined behavior
> -----------------------------------------------------------------
>
> Key: THRIFT-1248
> URL: https://issues.apache.org/jira/browse/THRIFT-1248
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.5
> Reporter: Anatoly Fayngelerin
> Assignee: James E. King, III
> Fix For: 0.9.3
>
> Attachments: 0_7_0_ptrdiff.patch
>
>
> The ensureCanWrite function in TMemoryBuffer currently "rebases" the buffer
> pointers by subtracting the original buffer pointer from the pointer newly
> returned by realloc. While this seems to work fine on my linux setup(I
> couldn't force a reproducer), pointer subtraction between pointers that we
> allocated separately is an undefined operation.
> I have run into problems with this on platforms other than linux.
> I am attaching a patch that removes the undefined operation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
