[
https://issues.apache.org/jira/browse/THRIFT-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537248#comment-14537248
]
Konstantin Shaposhnikov commented on THRIFT-3131:
-------------------------------------------------
git-wip-us.apache.org/repos/asf/thrift.git/lib/go/thrift path is mentioned only
in the README.txt
However both tutorial
(https://github.com/apache/thrift/blob/master/tutorial/go/src/server.go) and
thrift code generator
(https://github.com/apache/thrift/blob/master/compiler/cpp/src/generate/t_go_generator.cc)
use git.apache.org/thrift.git/lib/go/thrift path.
Should it be changed to
git-wip-us.apache.org/repos/asf/thrift.git/lib/go/thrift there? I think it
might break the existing users of thrift go.
> Make suggested import path for go thrift library consistent with generated
> code
> -------------------------------------------------------------------------------
>
> Key: THRIFT-3131
> URL: https://issues.apache.org/jira/browse/THRIFT-3131
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Compiler, Go - Library
> Reporter: Konstantin Shaposhnikov
>
> https://github.com/apache/thrift/blob/master/lib/go/README.md suggests to use
> the following import path for go thrift library:
> git-wip-us.apache.org/repos/asf/thrift.git/lib/go/thrift
> However thrift compiler uses different import path in the generated files by
> default:
> git.apache.org/thrift.git/lib/go/thrift
> To avoid confusion it would be good to use a single import path both in the
> generated code and in the user documentation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
