[ 
https://issues.apache.org/jira/browse/THRIFT-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545398#comment-14545398
 ] 

Konstantin Shaposhnikov commented on THRIFT-3131:
-------------------------------------------------

Sorry, I probably didn't explain the issue clearly enough. Let me try again:

1. git.apache.org/... import paths will never work with "go get" 1.4 or 
earlier. This doesn't mean that users won't be able to use thrift library. It 
only means that they will have to checkout it to the right location themselves 
using "git clone" instead of "go get".
2. if Apache adds HTTPS support to git.apache.org then git.apache.org/... 
import paths will work with "go get" 1.5 or later (given my patch is applied). 
The target release date for Go 1.5 is August, 1st
3. If Apache doesn't add HTTPS support then git.apache.org/... import paths 
won't be supported by Go even with -insecure option.



> Consolidate suggested import path for go thrift library to git.apache.org in 
> docs and code
> ------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-3131
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3131
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler, Go - Library
>            Reporter: Konstantin Shaposhnikov
>            Assignee: Konstantin Shaposhnikov
>
> https://github.com/apache/thrift/blob/master/lib/go/README.md suggests to use 
> the following import path for go thrift library:
> git-wip-us.apache.org/repos/asf/thrift.git/lib/go/thrift
> However thrift compiler uses different import path in the generated files by 
> default:
> git.apache.org/thrift.git/lib/go/thrift 
> To avoid confusion it would be good to use a single import path both in the 
> generated code and in the user documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to