[
https://issues.apache.org/jira/browse/THRIFT-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545680#comment-14545680
]
ASF GitHub Bot commented on THRIFT-3149:
----------------------------------------
GitHub user kostya-sh opened a pull request:
https://github.com/apache/thrift/pull/496
THRIFT-3149 go: make generated readFieldN methods private
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kostya-sh/thrift THRIFT-3149
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/496.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #496
----
commit 854527ca6b0eefbc6a551243682a6a792c09dade
Author: Konstantin Shaposhnikov <k.shaposhni...@gmail.com>
Date: 2015-05-15T15:35:45Z
THRIFT-3149 go: make generated readFieldN methods private
----
> Make ReadFieldN methods in generated Go code private
> ----------------------------------------------------
>
> Key: THRIFT-3149
> URL: https://issues.apache.org/jira/browse/THRIFT-3149
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler
> Affects Versions: 0.9.2
> Reporter: Konstantin Shaposhnikov
>
> The go thrift compiler generates ReadFieldN and writeFieldN methods for every
> field of a struct. E.g.:
> {code}
> func (p *Statistics) ReadField1(iprot thrift.TProtocol) error {
> ...
> }
> func (p *Statistics) writeField1(oprot thrift.TProtocol) (err error) {
> ...
> }
> {code}
> ReadField1, ReadField2, etc are not very descriptive names and shouldn't be
> part of public API of a generated package (like writeFieldN).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
