GitHub user kostya-sh opened a pull request:

    https://github.com/apache/thrift/pull/497

    THRIFT-3131 fix path for "go get"

    git.apache.org/thrift.git/lib/go/thrift is the correct import path as it is 
used
    by default in the generated go code.
    
    Unfortunately "go get" can download this library only using git:// scheme 
so if
    a user running "go get" is behind a firewall or Git is down at
    git.apache.org (which seems to be the case from time to time) then running 
go
    get with this path will fail.
    
    I will try to get this fixed in Go 1.5. Issues to watch:
    - https://issues.apache.org/jira/browse/INFRA-9658
    - https://github.com/golang/go/issues/10797

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kostya-sh/thrift THRIFT-3131

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/497.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #497
    
----
commit dfa022a0072d43ba16470c6b4572142cd87a4b62
Author: Konstantin Shaposhnikov <[email protected]>
Date:   2015-05-16T01:51:20Z

    THRIFT-3131 fix path for "go get"
    
    git.apache.org/thrift.git/lib/go/thrift is the correct import path as it is 
used
    by default in the generated go code.
    
    Unfortunately "go get" can download this library only using git:// scheme 
so if
    a user running "go get" is behind a firewall or Git is down at
    git.apache.org (which seems to be the case from time to time) then running 
go
    get with this path will fail.
    
    I will try to get this fixed in Go 1.5. Issues to watch:
    - https://issues.apache.org/jira/browse/INFRA-9658
    - https://github.com/golang/go/issues/10797

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to