[
https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546599#comment-14546599
]
ASF GitHub Bot commented on THRIFT-3112:
----------------------------------------
GitHub user mreve opened a pull request:
https://github.com/apache/thrift/pull/500
Typed AsyncMethodCallback with return type
In Java generator, a few occurrences of AsyncMethodCallback were typed with
function return type, and a few were not. Please correct me if it should be
typed differently.
See:
https://issues.apache.org/jira/browse/THRIFT-3112
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mreve/thrift THRIFT-3112
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/500.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #500
----
commit 85fba8d9134f4a51c34c79ce821bdfcb59637d3e
Author: Anna Dymek <[email protected]>
Date: 2015-05-16T06:49:07Z
Typed AsyncMethodCallback with return type.
----
> [Java] AsyncMethodCallback should be typed in generated AsyncIface
> ------------------------------------------------------------------
>
> Key: THRIFT-3112
> URL: https://issues.apache.org/jira/browse/THRIFT-3112
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Compiler
> Affects Versions: 0.9.2
> Reporter: Sergei Egorov
> Labels: easyfix
>
> AsyncMethodCallback is generic, but current Java code generator is not adding
> type info to it, and instead of:
> {code:java}
> public interface AsyncIface {
> public void ping(org.apache.thrift.async.AsyncMethodCallback<String>
> resultHandler) throws org.apache.thrift.TException;
> }
> {code}
> we have:
> {code:java}
> public interface AsyncIface {
> public void ping(org.apache.thrift.async.AsyncMethodCallback
> resultHandler) throws org.apache.thrift.TException;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
