Hi,

I’m not so sure if changing the style of certain constructs just for the sake 
of adhering to (more or less) arbitrary standards is really such a great idea. 
One example:

Original version

    to_string_mapping <<
                      indent() << "  }" << endl <<
                      indent() << "  return \"<UNSET>\"" << endl <<
                      indent() << "}" << endl;


After multiple “make style” and similar applied :

  to_string_mapping << indent() << "  }" << endl << indent() << "  return 
\"<UNSET>\"" << endl
                    << indent() << "}" << endl;

Is that really what we want? To me this only generates lots of noise in the 
code base and less readable code. To be honest, I have more and more problems 
to see the benefit of it. But since I am a constructive guy, I’d like to ask 
you: How can we improve the quality of those “Verschlimmbesserungen” [1]?

JensG

[1] That’s a german technical term. You may use Google Translate to find out 
what that means in your language.



Reply via email to