GitHub user kostya-sh opened a pull request:

    https://github.com/apache/thrift/pull/505

    THRIFT-3150 go: add option to generate non-exported Read and Write me…

    …thods
    
    This change adds a new option to Go trift compiler: dont_export_rw.
    
    When it is specified generated Read and Write methods will be called 'read' 
and
    'write' (and hence are non-exported).
    
    This can be useful if a package author wants to make the generated structs 
part
    of public package API but doesn't want the package depend on thrift
    library. This will make vendoring thrift library easier too.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kostya-sh/thrift THRIFT-3150

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/505.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #505
    
----
commit 0f06ab30179b1a70248e5d56a70e7f41d037695f
Author: Konstantin Shaposhnikov <[email protected]>
Date:   2015-05-20T14:26:26Z

    THRIFT-3150 go: add option to generate non-exported Read and Write methods
    
    This change adds a new option to Go trift compiler: dont_export_rw.
    
    When it is specified generated Read and Write methods will be called 'read' 
and
    'write' (and hence are non-exported).
    
    This can be useful if a package author wants to make the generated structs 
part
    of public package API but doesn't want the package depend on thrift
    library. This will make vendoring thrift library easier too.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to