Paul Magrath created THRIFT-3174:
------------------------------------

             Summary: Initialism code in the Go compiler doesn't check first 
word
                 Key: THRIFT-3174
                 URL: https://issues.apache.org/jira/browse/THRIFT-3174
             Project: Thrift
          Issue Type: Bug
          Components: Go - Compiler
    Affects Versions: 0.9.3
            Reporter: Paul Magrath
            Priority: Minor


The Go compiler, when checking for common initialisms in the process of 
converting to camelcase, fails to check the first word of the name, only 
checking the subsequent words. As such, if you have a Thrift struct like:-

{code}
struct Foo {
    1: string user_id,
    2: string server_url,
    3: string id, 
}
{code}

You get a Go struct of the form:-

{code}
type Foo struct {
        UserID    string `thrift:"user_id,1" json:"user_id"`
        ServerURL string `thrift:"server_url,2" json:"server_url"`
        Id        string `thrift:"id,3" json:"id"`
}
{code}

Instead of:-

{code}
type Foo struct {
        UserID    string `thrift:"user_id,1" json:"user_id"`
        ServerURL string `thrift:"server_url,2" json:"server_url"`
        ID        string `thrift:"id,3" json:"id"`
}
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to