[
https://issues.apache.org/jira/browse/THRIFT-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589050#comment-14589050
]
ASF GitHub Bot commented on THRIFT-3192:
----------------------------------------
GitHub user beberg opened a pull request:
https://github.com/apache/thrift/pull/523
THRIFT-3192 Go import paths changed in 1.4, and expired June 1
Modified imports from code.google to github locations.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/beberg/thrift THRIFT-3192
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/523.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #523
----
commit 659e8f20cf1dc4455565f0295b1550a4805064ea
Author: Adam Beberg <[email protected]>
Date: 2015-05-31T04:35:01Z
Merge pull request #1 from apache/master
Pull from upstream
commit 0ec454a7d313276d1242dc07c044cd3b32b6c29b
Author: Adam Beberg <[email protected]>
Date: 2015-06-16T22:53:14Z
Merge pull request #2 from apache/master
Pull from upstream
commit c978ce9faabd98cec79072dc5bf5e3baf493b762
Author: Adam Beberg <[email protected]>
Date: 2015-06-16T23:32:58Z
THRIFT-3192 Go import paths changed in 1.4, and expired June 1
commit 9a20b5a4c60be85aa624470325ff1528d9a9891a
Author: Adam Beberg <[email protected]>
Date: 2015-06-17T00:00:50Z
THRIFT-3192 Go import paths changed in 1.4, and expired June 1
----
> Go import paths changed in 1.4, and expired June 1
> --------------------------------------------------
>
> Key: THRIFT-3192
> URL: https://issues.apache.org/jira/browse/THRIFT-3192
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Reporter: Adam Beberg
> Assignee: Adam Beberg
> Priority: Blocker
> Fix For: 0.9.3
>
>
> (Preparing pull request now)
> From 1.4 release notes:
> The Go project subrepositories (code.google.com/p/go.tools and so on) are now
> available under custom import paths replacing code.google.com/p/go. with
> golang.org/x/, as in golang.org/x/tools. We will add canonical import
> comments to the code around June 1, 2015, at which point Go 1.4 and later
> will stop accepting the old code.google.com paths.
> Updating: All code that imports from subrepositories should change to use the
> new golang.org paths. Go 1.0 and later can resolve and import the new paths,
> so updating will not break compatibility with older releases. Code that has
> not updated will stop compiling with Go 1.4 around June 1, 2015."
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
