[ 
https://issues.apache.org/jira/browse/THRIFT-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593892#comment-14593892
 ] 

Jens Geyer commented on THRIFT-3193:
------------------------------------

{quote}
Alternatively, if you want to include the date, it should be based on a stable 
value (e.g. last-modified timestamp of the originating .thrift).
{quote}

Not quite. Here's what [the Java 
Docs|http://docs.oracle.com/javase/7/docs/api/javax/annotation/Generated.html] 
say:

{quote}
The date element is used to *indicate the date the source was generated*. 
{quote}

So either you generate them every day and get a new timestamp, or you don't. 

Since both {{Date}} and {{Comment}} fields are considered optional, I am fine 
with the proposed change. [Feel free to provide a patch or 
PR|http://thrift.apache.org/docs/HowToContribute]. If someone else has 
objections, please chime in.



> Option to supress date value in @Generated annotation
> -----------------------------------------------------
>
>                 Key: THRIFT-3193
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3193
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Compiler
>    Affects Versions: 0.9.2
>            Reporter: Vitali Lovich
>
> https://issues.apache.org/jira/browse/THRIFT-1813 added the \@Generated 
> annotation but didn't provide a way to turn off generating the date.  This 
> causes issues in our automation which enforces that the generated files are 
> always unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to