[
https://issues.apache.org/jira/browse/THRIFT-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602461#comment-14602461
]
ASF GitHub Bot commented on THRIFT-3204:
----------------------------------------
GitHub user wangjild opened a pull request:
https://github.com/apache/thrift/pull/529
[THRIFT-3204] SimpleServer processRequests method nerver handle some errors
SimpleServer processRequests method nerver handle some errors which is not
thrift.TTransportException type
https://issues.apache.org/jira/browse/THRIFT-3204
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wangjild/thrift THRIFT-3204
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/529.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #529
----
commit 26976d135ae1cff4fceea16884cbdb62ea04671d
Author: Wang Jing <[email protected]>
Date: 2015-06-26T06:09:31Z
SimpleServer processRequests method nerver handle errors which is not
thrift.TTransportException type
----
> SimpleServer process loop missed handle some error
> --------------------------------------------------
>
> Key: THRIFT-3204
> URL: https://issues.apache.org/jira/browse/THRIFT-3204
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Affects Versions: 0.9.2
> Reporter: Jing Wang
> Labels: patch
> Fix For: 0.9.3
>
>
> SimpleServer do not handle all errors returned by processor.
> When a error returned by processor.Process methods In SimpleServer's
> processRequests, program will omit this error and log nothing to the
> programmer if this error is not thrift.TTransportException type.
> If a Protocol error happens, the server will close the client connection and
> log nothing,
> This bug is cause by a wrong "else if" condition. In the if esle condition,
> the inside variable "err" will cover the scope of outside "err", and it will
> always be "nil", the "else if" condition will never reached
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
