GitHub user ben-craig reopened a pull request:
https://github.com/apache/thrift/pull/534
THRIFT-2850: Fix some Windows CMake issues
Some issues that are fixed here:
* Removed some files from the build that do nothing except for cause
warnings on Windows (VirtualProfiling.cpp and Server.cpp)
* Fix includes for latest version of libevent. Allegedly the entry points
that libthriftnb use are deprecated, and require extra header includes.
* Fully qualifying apache::thrift::concurrency, because MSVC does funky
things with an unadorned concurrency namespace.
* Added missing dependency include paths to test binaries
* Ensured that tests are built against the proper static / shared versions
of Thrift.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ben-craig/thrift THRIFT-2850
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/534.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #534
----
commit 96c84cb0090ceab39f3c1992e5935feb8d7feed3
Author: Ben Craig <[email protected]>
Date: 2015-06-28T01:32:56Z
Fixing core lib building issues with libevent and msvc concurrency
namespace.
commit 78e964b4f9a79ce972a7b171043d0db83846a3aa
Author: Ben Craig <[email protected]>
Date: 2015-06-30T00:42:44Z
Making tests build
commit 347fd09fc0de9dd9bee17ee9bff966a21db1a1cb
Author: Ben Craig <[email protected]>
Date: 2015-06-30T00:57:24Z
Merge c:/src/thrift into THRIFT-2850
commit 873af4328bfdb2e004c1e729af91217554347f09
Author: Ben Craig <[email protected]>
Date: 2015-06-30T01:13:12Z
Cleaning up comments
commit 8594253824d01ef961291ee20fdb251658a6f50b
Author: Ben Craig <[email protected]>
Date: 2015-06-30T01:13:27Z
Merge c:/src/thrift into THRIFT-2850
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
