[ https://issues.apache.org/jira/browse/THRIFT-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612735#comment-14612735 ]
James E. King, III commented on THRIFT-3211: -------------------------------------------- [~roger.meier], [~jensg] this change significantly improved PHP test coverage and passed a Travis CI. Please merge? > Add make cross support for php TCompactProtocol > ----------------------------------------------- > > Key: THRIFT-3211 > URL: https://issues.apache.org/jira/browse/THRIFT-3211 > Project: Thrift > Issue Type: Test > Components: PHP - Library, Test Suite > Affects Versions: 0.9.2 > Reporter: James E. King, III > Assignee: James E. King, III > Priority: Minor > > In working on THRIFT-878 I found that the PHP client does not test > TCompactProtocol in {{make cross}}. I fixed the php test client locally and > was able to get it to pass when using cpp as the server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)