[
https://issues.apache.org/jira/browse/THRIFT-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614672#comment-14614672
]
ASF GitHub Bot commented on THRIFT-1522:
----------------------------------------
Github user cmhe commented on the pull request:
https://github.com/apache/thrift/pull/542#issuecomment-118762338
I have run "make cross" and "make check" without any unexpected errors.
Feedback is welcome.
> TServerSocket potential memory leak with addrinfo *res0
> -------------------------------------------------------
>
> Key: THRIFT-1522
> URL: https://issues.apache.org/jira/browse/THRIFT-1522
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.8
> Environment: Unix, Windows
> Reporter: Peace C
> Priority: Minor
> Labels: TServerSocket, leak, memory, thrift
> Fix For: 1.0
>
>
> I noticed a potential memory leak in TServerSocket.cpp. The res0 pointer
> receives an allocation from getaddrinfo() but is only freed part of the time
> in a conditional branch. It should be outside of the if-else to ensure it's
> deallocated every time.
> I'm holding off on creating a patch in case I'm not understanding some hidden
> functionality in the socket library. Here is the code snippet:
> struct addrinfo *res0;
> ...
> getaddrinfo(NULL, port, &hints, &res0);
> ...
> if (! path_.empty())
> { ... }
> else
> {
> ...
> freeaddrinfo(res0); //Line 331 of TServerSocket.cpp
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
