[ 
https://issues.apache.org/jira/browse/THRIFT-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636097#comment-14636097
 ] 

Jake Farrell commented on THRIFT-2921:
--------------------------------------

Using the default Erlang from Ubuntu Trusty 1:16.b.3-dfsg-1ubuntu2.1 errors 
where directly related to the two changes made in the patch for dict and set

{code}
test/gen-erl/thrift1475_types.hrl:30: referring to built-in type set as a 
remote type; please take out the module name
test/gen-erl/thrift_test_types.hrl:48: referring to built-in type dict as a 
remote type; please take out the module name
test/gen-erl/thrift1475_types.hrl:31: referring to built-in type set as a 
remote type; please take out the module name
test/gen-erl/thrift_test_types.hrl:55: referring to built-in type set as a 
remote type; please take out the module name
test/gen-erl/thrift1475_types.hrl:32: referring to built-in type set as a 
remote type; please take out the module name
test/gen-erl/thrift_test_types.hrl:99: referring to built-in type set as a 
remote type; please take out the module name
test/gen-erl/thrift_test_types.hrl:100: referring to built-in type dict as a 
remote type; please take out the module name
test/gen-erl/thrift1475_types.hrl:33: referring to built-in type dict as a 
remote type; please take out the module name
test/gen-erl/thrift_test_types.hrl:119: referring to built-in type dict as a 
remote type; please take out the module name
test/gen-erl/thrift1475_types.hrl:34: referring to built-in type dict as a 
remote type; please take out the module name
test/gen-erl/thrift1475_types.hrl:35: referring to built-in type dict as a 
remote type; please take out the module name
test/gen-erl/thrift_test_types.hrl:131: referring to built-in type set as a 
remote type; please take out the module name
{code}


> Make Erlang impl ready for OTP 18 release (dict/0 and set/0 are deprecated)
> ---------------------------------------------------------------------------
>
>                 Key: THRIFT-2921
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2921
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Erlang - Compiler
>            Reporter: Jens Geyer
>            Assignee: Michael Oliver
>             Fix For: 0.9.3
>
>
> Using Erlang OTP 17, I get the following deprecation warnings:
> {code}
> en-erl/thrift_test_types.hrl:48: Warning: type dict/0 is deprecated and will 
> be removed in OTP 18.0; use use dict:dict/0 or preferably dict:dict/2
> gen-erl/thrift_test_types.hrl:55: Warning: type set/0 is deprecated and will 
> be removed in OTP 18.0; use use sets:set/0 or preferably sets:set/1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to