[
https://issues.apache.org/jira/browse/THRIFT-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639717#comment-14639717
]
ASF GitHub Bot commented on THRIFT-3255:
----------------------------------------
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/561
THRIFT-3255 Thrift generator doesn't exclude 'package' keyword for Java
The patch adds "package" to the global list of reserved keywords, because
it is used as keyword in Java, ActionScript, Go, Haxe, Perl.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift THRIFT-3255
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/561.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #561
----
commit af85d6188d5d783f2f511692fc4048cf6ef318e7
Author: Jens Geyer <[email protected]>
Date: 2015-07-24T00:14:43Z
THRIFT-3255 Thrift generator doesn't exclude 'package' keyword for thrift
property names breaking java builds
Client: Java
Patch: Jens Geyer
----
> Thrift generator doesn't exclude 'package' keyword for thrift property names
> breaking java builds
> -------------------------------------------------------------------------------------------------
>
> Key: THRIFT-3255
> URL: https://issues.apache.org/jira/browse/THRIFT-3255
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
> Affects Versions: 0.9.2
> Reporter: Matt Wolfe
>
> Thrift allows the word "package" for it's property names which when
> generating java will not compile.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
