[
https://issues.apache.org/jira/browse/THRIFT-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651970#comment-14651970
]
Randy Abernethy edited comment on THRIFT-2199 at 8/3/15 5:16 PM:
-----------------------------------------------------------------
This patch removes the experimental dense protocol implementation including
four files and over 2,000 lines of code. This should not impact any Apache
Thrift implementation unless said implementation is using the dense protocol.
Email was sent to user and dev thrift mailing lists on 8/3/2015 to alert any
possible users of the imminent removal.
The experimental dense code was removed because it increased complexity and
represented a significant maintenance burden in the compiler and C++ library
without providing utility to the general community.
Dense was only implemented in C++ and therefore was not workable in cross
language settings. The TZLib transport layer (present in Java, Python, C++ and
other languages) is a possible alternative for cross platform/language high
compression applications.
The dense code created fingerprints in all generated C++ code files for all
types whether dense was enabled or not. Users hijacking Dense fingerprints for
their own uses will need to implement an equivalent custom feature.
The "--gen cpp:dense" IDL compiler qualifier and four files have been removed:
- lib/cpp/src/thrift/TReflectionLocal.h
- lib/cpp/src/thrift/protocol/TDenseProtocol.cpp
- lib/cpp/src/thrift/protocol/TDenseProtocol.h
- lib/cpp/test/DenseProtoTest.cpp
along with their associated build/test drivers.
was (Author: codesf):
patch
> Move Dense protocol to Contrib
> ------------------------------
>
> Key: THRIFT-2199
> URL: https://issues.apache.org/jira/browse/THRIFT-2199
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Affects Versions: 1.0
> Environment: All
> Reporter: Randy Abernethy
> Assignee: Randy Abernethy
> Priority: Minor
> Fix For: 0.9.3
>
> Attachments: 0001-dense-removal.patch
>
>
> In response to recent emails I suggest we move the Dense protocol to contrib.
> It is in an experimental state (per comments) and has not been enhanced for
> over three years. It impacts complexity of Thrift in a fairly broad fashion,
> having bearing on compilation and compiler output even when not used. If no
> one disagrees with this action I would be happy to put a patch together to
> relocate dense to contrib.
> Would fix THRIFT-2200
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
