[ 
https://issues.apache.org/jira/browse/THRIFT-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652577#comment-14652577
 ] 

Hudson commented on THRIFT-3285:
--------------------------------

SUCCESS: Integrated in Thrift #1637 (See 
[https://builds.apache.org/job/Thrift/1637/])
THRIFT-3285 c_glib: Library: Use AM_CPPFLAGS for include paths, not AM_CFLAGS 
(roger: rev 31186c467a3bcfc8408592372f998a31e5723281)
* lib/c_glib/Makefile.am
THRIFT-3285 c_glib: Library: Build with all warnings enabled (roger: rev 
b62093db94a8505ebc6bac621e257682f12f1ac7)
* lib/c_glib/Makefile.am
THRIFT-3285 c_glib: Library: Build without compiler warnings (roger: rev 
89e65def89beed72340f5eacac5b50a70fd6d062)
* lib/c_glib/src/thrift/c_glib/server/thrift_simple_server.c
* lib/c_glib/src/thrift/c_glib/transport/thrift_framed_transport.c
* lib/c_glib/src/thrift/c_glib/thrift.c
* lib/c_glib/src/thrift/c_glib/transport/thrift_server_socket.c
* lib/c_glib/src/thrift/c_glib/transport/thrift_socket.c
* lib/c_glib/src/thrift/c_glib/protocol/thrift_binary_protocol_factory.c
* lib/c_glib/src/thrift/c_glib/processor/thrift_dispatch_processor.c
* lib/c_glib/src/thrift/c_glib/transport/thrift_memory_buffer.c
* lib/c_glib/src/thrift/c_glib/transport/thrift_buffered_transport.c
* lib/c_glib/src/thrift/c_glib/protocol/thrift_binary_protocol.c


> c_glib: Build library with all warnings enabled, no warnings generated
> ----------------------------------------------------------------------
>
>                 Key: THRIFT-3285
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3285
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C glib - Library
>    Affects Versions: 0.9.3
>         Environment: Cloud9 (Ubuntu 14.04.2 LTS; gcc 4.8.2)
>            Reporter: Simon South
>            Assignee: Simon South
>            Priority: Minor
>              Labels: c_glib, library, warnings
>             Fix For: 0.9.3
>
>
> For correctness and to help with tracking down bugs, the C (GLib) library 
> should build with the same compiler-warning options enabled for the C++ 
> library ({{-Wall -Wextra -pedantic}}) and without any warnings generated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to