[
https://issues.apache.org/jira/browse/THRIFT-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaoshuang LU updated THRIFT-3298:
----------------------------------
Description: Thrift C++ library offers some endian converters in
TProtocol.h, e.g. ntohll, htonll, and etc. Some other libraries may also have
these kinds of converters, such as ZooKeeper. And if we include TProtocol.h
prior to zookeeper.h, zookeeper's htonll will be replaced by the thrift macros
mentioned above. Consequently, I propose that we may add prefix "THRIFT_" to
all these converters. (was: Thrift C++ library offers some endian converters
in TProtocol.h, e.g. ntohll, htonll, and etc. Some other libraries may also
have these kinds of converters, such as ZooKeeper. And if we include
TProtocol.h in prior to zookeeper.h, zookeeper's htonll will be replaced by the
thrift macros. Consequently, I propose that we may add prefix "THRIFT_" to
these converters.)
Summary: thrift endian converters may conflict with other libraries
(was: thrift endian converter may conflict with other libraries)
> thrift endian converters may conflict with other libraries
> ----------------------------------------------------------
>
> Key: THRIFT-3298
> URL: https://issues.apache.org/jira/browse/THRIFT-3298
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9.2
> Reporter: Xiaoshuang LU
> Fix For: 0.9.3
>
>
> Thrift C++ library offers some endian converters in TProtocol.h, e.g. ntohll,
> htonll, and etc. Some other libraries may also have these kinds of
> converters, such as ZooKeeper. And if we include TProtocol.h prior to
> zookeeper.h, zookeeper's htonll will be replaced by the thrift macros
> mentioned above. Consequently, I propose that we may add prefix "THRIFT_" to
> all these converters.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
