[
https://issues.apache.org/jira/browse/THRIFT-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716832#comment-14716832
]
Jake Farrell commented on THRIFT-3308:
--------------------------------------
[~roger.meier] sorry, dont think i worded my question too clearly. Understand
how the py tests are included, the test/py/CMakeLists.txt file iteself contains
some issues in it and from what I can see has never worked. Based on the
following issues I am proposing that we remove it for now to help get 0.9.3 out
the door and recreate/enable the py tests in cmake when pushing towards 1.0 and
full cmake support
issues with test/py/CMakeLists.txt
- add_test contains a DEPENDS which is not an available cmake option for
add_test. add_property PROPERTY DEPENDS would be the correct approach for
add_test to have a dependency.
- the custom_command used to generate the gen-py-default and other bindings
uses the thrift -out flag which requires that the directory specified to the
-out flag exist, these commands always fail the way they are written
- custom_command is a build time trigger and from what I recall can not run
during test. execute_process would be able to run here, but would run every
time and not reuse the directory.
> Fix broken test cases for 0.9.3 release candidate
> -------------------------------------------------
>
> Key: THRIFT-3308
> URL: https://issues.apache.org/jira/browse/THRIFT-3308
> Project: Thrift
> Issue Type: Sub-task
> Components: Build Process
> Reporter: Jake Farrell
> Assignee: Jake Farrell
> Fix For: 0.9.3
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
