[
https://issues.apache.org/jira/browse/THRIFT-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791176#comment-14791176
]
ASF GitHub Bot commented on THRIFT-3108:
----------------------------------------
GitHub user jpgneves opened a pull request:
https://github.com/apache/thrift/pull/607
THRIFT-3108 Defaulted struct parameters on a service generates invali…
…d Haskell
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpgneves/thrift THRIFT-3108
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/607.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #607
----
commit d5a3edd28ce41dccd4a881cc9c26e411f2aa3de8
Author: João Neves <seve...@gmail.com>
Date: 2015-09-16T20:39:28Z
THRIFT-3108 Defaulted struct parameters on a service generates invalid
Haskell
----
> Defaulted struct parameters on a service generates invalid Haskell.
> -------------------------------------------------------------------
>
> Key: THRIFT-3108
> URL: https://issues.apache.org/jira/browse/THRIFT-3108
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Compiler
> Environment: GHC 7.6.3
> GHC 7.8.4
> Reporter: Sean Parsons
> Priority: Blocker
>
> If we have a service definition that looks something like:
> {code:none}
> struct ServiceRequest {
> 1: optional bool shouldWork;
> }
> service MyService{
> void myService(1:ServiceRequest request = {});
> }
> {code}
> The code generation relating to the service call includes an invocation like
> this:
> {code:none}
> ... = default_ServiceRequest{}
> {code}
> Which is invalid as empty record updates are not allowed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
