[
https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907086#comment-14907086
]
James E. King, III commented on THRIFT-2473:
--------------------------------------------
I think the generated code which emits __set_<name> methods should also set the
isset flag automatically. This doesn't happen today as I just looked at some
generated code and I expected __set_foo to not only assign a value to foo but
also to set the isset flag for foo. Perhaps that could be done at the same
time as this work...
> _isset entries shouldn't be generated for non-optional fields
> -------------------------------------------------------------
>
> Key: THRIFT-2473
> URL: https://issues.apache.org/jira/browse/THRIFT-2473
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler
> Reporter: Vitali Lovich
>
> There's quite a bit of memory overhead (4 bytes per field) that's wasted on
> every single type. The __isset field is unused by the thrift type for fields
> not annotated optional.
> Additionally, it causes confusion in program code since people never know
> whether or not the __isset struct can be checked for a particular field or
> not (e.g. for non-optional fields it would never get set normally unless you
> deserialized it).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
