[
https://issues.apache.org/jira/browse/THRIFT-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907520#comment-14907520
]
Hudson commented on THRIFT-3298:
--------------------------------
SUCCESS: Integrated in Thrift #1664 (See
[https://builds.apache.org/job/Thrift/1664/])
THRIFT-3298: thrift endian converters may conflict with other libraries
(jfarrell: rev ad3a95527cb9cddce38d0c0207ede174b556f972)
* lib/cpp/src/thrift/protocol/TCompactProtocol.tcc
* lib/cpp/src/thrift/protocol/TProtocol.h
> thrift endian converters may conflict with other libraries
> ----------------------------------------------------------
>
> Key: THRIFT-3298
> URL: https://issues.apache.org/jira/browse/THRIFT-3298
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9.2
> Reporter: Xiaoshuang LU
> Fix For: 0.9.3
>
> Attachments: THRIFT-3298.patch
>
>
> Thrift C++ library offers some endian converters in TProtocol.h, e.g. ntohll,
> htonll, and etc. Some other libraries may also have these kinds of
> converters, such as ZooKeeper. And if we include TProtocol.h prior to
> zookeeper.h, zookeeper's htonll will be replaced by the thrift macros
> mentioned above. Consequently, I propose that we may add prefix "THRIFT_" to
> all these converters.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
