[
https://issues.apache.org/jira/browse/THRIFT-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907943#comment-14907943
]
ASF GitHub Bot commented on THRIFT-3336:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/626
THRIFT-3336: eliminate extraneous ostream operators in generated code…
…; provide an overridable ostream implementation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3336
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/626.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #626
----
commit 0c74ec5b963c52122036e7559120180023a3527d
Author: James E. King, III <[email protected]>
Date: 2015-09-23T15:37:44Z
THRIFT-3336: eliminate extraneous ostream operators in generated code;
provide an overridable ostream implementation
----
> Thrift generated streaming operators added in 0.9.2 cannot be overridden
> ------------------------------------------------------------------------
>
> Key: THRIFT-3336
> URL: https://issues.apache.org/jira/browse/THRIFT-3336
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler
> Affects Versions: 0.9.2, 0.9.3
> Reporter: James E. King, III
> Assignee: James E. King, III
>
> I work on one project that has been using thrift-0.8.0 and I am updating it
> to 0.9.3. The project defines streaming operators for "operator <<" on a
> variety of thrift-generated types.
> The fix added in THRIFT-2067 provides similar but not identical functionality
> however it was done in a way that cannot be overridden, and this causes
> projects upgrading from versions prior to 0.9.2 with their own streaming
> operators to fail to compile.
> One way to make the streaming operator virtual is to follow the example
> provided in
> http://stackoverflow.com/questions/5189614/operator-and-inheritance
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
