[jira] [Commented] (THRIFT-3230) Python compiler generates wrong code if there is function throwing a typedef of exception with another namespace

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/THRIFT-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14950240#comment-14950240
 ] 

ASF GitHub Bot commented on THRIFT-3230:
----------------------------------------

Github user lifei commented on the pull request:

    https://github.com/apache/thrift/pull/545#issuecomment-146838596
  
    
https://github.com/apache/thrift/commit/01a77ab01e7459d96059a2b49d9885d14a360ef1


> Python compiler generates wrong code if there is function throwing a typedef 
> of exception with another namespace
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-3230
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3230
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Compiler
>    Affects Versions: 0.9.2
>            Reporter: 李飛
>            Assignee: 李飛
>            Priority: Blocker
>             Fix For: 0.9.3
>
>
> for example:
> {code:title=error.thrift}
> namespace py error
> exception KolodaException {
>     string message
> }
> {code}
> {code:title=biz.thrift}
> namespace py biz
> include "error.thrift"
> typedef error.KolodaException KolodaException
> BizService {
>     void doSomeBiz() throws (1: KolodaException ex)
> }
> {code}
> compiled code
> {code}
>     try:
>       result.success = self._handler.doSomeBiz()
>     except KolodaException as ex:
>       result.ex = ex
> {code}
> `except KolodaException as ex:` should be `except error.KolodaException as 
> ex:`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)