[
https://issues.apache.org/jira/browse/THRIFT-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957640#comment-14957640
]
ASF GitHub Bot commented on THRIFT-3382:
----------------------------------------
Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/653#discussion_r42045161
--- Diff: compiler/cpp/src/generate/t_cpp_generator.cc ---
@@ -116,7 +116,8 @@ class t_cpp_generator : public t_oop_generator {
bool read = true,
bool write = true,
bool swap = false,
- bool stream = false);
+ bool stream = false,
+ bool is_struct = false);
--- End diff --
couple of solutions:
- convert some of those bools into enum (especially that is_exception=true
and is_struct=true can be set but it's a nonsense) [imho preferred]
- rename `bool stream` to `is_not_internal` or something like that (it was
also added to distinguish internal structs and normal ones)
- do not bother that internal structs inherit from TBase, they're structs
anyway
> TBase class for C++ Library
> ---------------------------
>
> Key: THRIFT-3382
> URL: https://issues.apache.org/jira/browse/THRIFT-3382
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler, C++ - Library
> Affects Versions: 0.9.3
> Reporter: Adam Beberg
> Assignee: Adam Beberg
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Unlike Other languages, C++ is missing a TBase class (the majority of other
> langugaes call it that) that all generated structs always inherit from. This
> prevents simple utility functions, and forces ugly template use.
> Something like this:
> {code:title=thtift/TBase.h}
> class TBase {
> public:
> virtual ~TBase();
> virtual uint32_t read(::apache::thrift::protocol::TProtocol* iprot);
> virtual uint32_t write(::apache::thrift::protocol::TProtocol* oprot) const;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
