Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/653#discussion_r42045161
--- Diff: compiler/cpp/src/generate/t_cpp_generator.cc ---
@@ -116,7 +116,8 @@ class t_cpp_generator : public t_oop_generator {
bool read = true,
bool write = true,
bool swap = false,
- bool stream = false);
+ bool stream = false,
+ bool is_struct = false);
--- End diff --
couple of solutions:
- convert some of those bools into enum (especially that is_exception=true
and is_struct=true can be set but it's a nonsense) [imho preferred]
- rename `bool stream` to `is_not_internal` or something like that (it was
also added to distinguish internal structs and normal ones)
- do not bother that internal structs inherit from TBase, they're structs
anyway
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
