[
https://issues.apache.org/jira/browse/THRIFT-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960757#comment-14960757
]
ASF GitHub Bot commented on THRIFT-3390:
----------------------------------------
GitHub user c4urself opened a pull request:
https://github.com/apache/thrift/pull/654
THRIFT-3390 Tornado server should gracefully handle closed connections
If END_OF_FILE exception is met the Tornado server should just break
the loop and close the connection instead of raising an exception
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Tubular/thrift fix/THRIFT-3390
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/654.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #654
----
commit 54b475ab746adfb07c5df3a3a243ec9297ddf9f5
Author: Christian Verkerk <[email protected]>
Date: 2015-10-16T14:08:11Z
THRIFT-3390 Tornado server should gracefully handle closed connections
If END_OF_FILE exception is met the Tornado server should just break
the loop and close the connection instead of raising an exception
----
> TTornado server doesn't handle closed connections properly
> ----------------------------------------------------------
>
> Key: THRIFT-3390
> URL: https://issues.apache.org/jira/browse/THRIFT-3390
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Affects Versions: 0.9.3
> Reporter: Christian Verkerk
>
> The Tornado Thrift server uses a TTornadoStreamTransport that uses Tornado's
> IOStream to handle incoming connections. The main method for handling this is
> a while loop in `handle_stream` that waits for incoming data. This works
> fine until the client decides to stop the connection in which case
> TTransportException.END_OF_FILE is raised. This exception is expected
> behaviour and should be caught appropriately in `handle_stream`.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
