Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/656#discussion_r42545542
--- Diff: test/ThriftTest.thrift ---
@@ -86,7 +86,7 @@ struct Xtruct
struct Xtruct2
{
- 1: byte byte_thing,
+ 1: i8 byte_thing, // used to be byte, hence the name
--- End diff --
Agree, but one of my goals was to break it down into small changes to
prevent us from ending up with a monster patch. This could be one of the next
steps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
